updated readme
This commit is contained in:
parent
297bed46bb
commit
81aacd98f0
|
|
@ -11,7 +11,6 @@ This is a solution to the [Skilled e-learning landing page challenge on Frontend
|
|||
- [My process](#my-process)
|
||||
- [Built with](#built-with)
|
||||
- [What I learned](#what-i-learned)
|
||||
- [Continued development](#continued-development)
|
||||
- [Useful resources](#useful-resources)
|
||||
- [Author](#author)
|
||||
- [Acknowledgments](#acknowledgments)
|
||||
|
|
@ -29,15 +28,9 @@ Users should be able to:
|
|||
|
||||
### Screenshot
|
||||
|
||||
|
||||
|
||||
Add a screenshot of your solution. The easiest way to do this is to use Firefox to view your project, right-click the page and select "Take a Screenshot". You can choose either a full-height screenshot or a cropped one based on how long the page is. If it's very long, it might be best to crop it.
|
||||
|
||||
Alternatively, you can use a tool like [FireShot](https://getfireshot.com/) to take the screenshot. FireShot has a free option, so you don't need to purchase it.
|
||||
|
||||
Then crop/optimize/edit your image however you like, add it to your project, and update the file path in the image above.
|
||||
|
||||
**Note: Delete this note and the paragraphs above when you add your screenshot. If you prefer not to add a screenshot, feel free to remove this entire section.**
|
||||
|
||||
|
||||
|
||||
|
||||
### Links
|
||||
|
||||
|
|
@ -46,66 +39,48 @@ Then crop/optimize/edit your image however you like, add it to your project, and
|
|||
|
||||
## My process
|
||||
|
||||
Built Mobile first, then expanded to Tablet and then Desktop.
|
||||
|
||||
At each stage I was checking how my build looked compared to the design in Polypane. (I generated images from Figma) I did try a little to get it close to "pixel perfect", which I do know I shouldn't :) As Grace on Slack would note don't try, and shared this [article](https://www.joshwcomeau.com/css/pixel-perfection/) by Josh Comeau.
|
||||
|
||||
I actually finished the build 5 days ago, but wasn't happy with how it handled responsively in the between sides. I stalled and then today realised I could have `margin-inline: auto` for the mobile to tablet size, and then use `justify-content: center` for tablet to desktop. So now it looks "reasonable" between. I did try breaking earlier to the desktop sizings but decided to leave it at 1440px / 90rem.
|
||||
|
||||
### Built with
|
||||
|
||||
- Semantic HTML5 markup
|
||||
- CSS custom properties
|
||||
- Flexbox
|
||||
- CSS Grid
|
||||
- Mobile-first workflow
|
||||
- [React](https://reactjs.org/) - JS library
|
||||
- [Next.js](https://nextjs.org/) - React framework
|
||||
- [Styled Components](https://styled-components.com/) - For styles
|
||||
|
||||
**Note: These are just examples. Delete this note and replace the list above with your own choices**
|
||||
|
||||
### What I learned
|
||||
|
||||
Use this section to recap over some of your major learnings while working through this project. Writing these out and providing code samples of areas you want to highlight is a great way to reinforce your own knowledge.
|
||||
Really it was mostly using `picture` and `source` tags properly. I tried to use `img srcset` but just couldn't get the following to work as I understood the docs to say.
|
||||
|
||||
To see how you can add code snippets, see below:
|
||||
|
||||
```html
|
||||
<h1>Some HTML code I'm proud of</h1>
|
||||
```
|
||||
```css
|
||||
.proud-of-this-css {
|
||||
color: papayawhip;
|
||||
}
|
||||
<img src="assets/logo-dark.svg" srcset="
|
||||
assets/image-hero-mobile.png 435w,
|
||||
assets/image-hero-tablet.png 695w,
|
||||
assets/image-hero-desktop.png 1046w" sizes="
|
||||
(max-width: 767px) 87vw,
|
||||
(max-width: 1439px) 83vw,
|
||||
(max-width: 2000px) 870px,
|
||||
1000px"
|
||||
alt="Woman blowing onto a mug. Top right of her is a box indicating 29k Members. On the bottom right is a box indicating 1,451 Course Hours."
|
||||
class="">
|
||||
```
|
||||
```js
|
||||
const proudOfThisFunc = () => {
|
||||
console.log('🎉')
|
||||
}
|
||||
```
|
||||
|
||||
If you want more help with writing markdown, we'd recommend checking out [The Markdown Guide](https://www.markdownguide.org/) to learn more.
|
||||
|
||||
**Note: Delete this note and the content within this section and replace with your own learnings.**
|
||||
|
||||
### Continued development
|
||||
|
||||
Use this section to outline areas that you want to continue focusing on in future projects. These could be concepts you're still not completely comfortable with or techniques you found useful that you want to refine and perfect.
|
||||
|
||||
**Note: Delete this note and the content within this section and replace with your own plans for continued development.**
|
||||
|
||||
### Useful resources
|
||||
|
||||
- [Example resource 1](https://www.example.com) - This helped me for XYZ reason. I really liked this pattern and will use it going forward.
|
||||
- [Example resource 2](https://www.example.com) - This is an amazing article which helped me finally understand XYZ. I'd recommend it to anyone still learning this concept.
|
||||
|
||||
**Note: Delete this note and replace the list above with resources that helped you during the challenge. These could come in handy for anyone viewing your solution or for yourself when you look back on this project in the future.**
|
||||
- [Responsive Images MDN](https://developer.mozilla.org/en-US/docs/Learn/HTML/Multimedia_and_embedding/Responsive_images) - Helped with using picture/source/img correctly.
|
||||
- [Guide to Responsive Images - CSS Tricks](https://css-tricks.com/a-guide-to-the-responsive-images-syntax-in-html/#using-picture)
|
||||
|
||||
## Author
|
||||
|
||||
- Website - [Add your name here](https://www.your-site.com)
|
||||
- Frontend Mentor - [@yourusername](https://www.frontendmentor.io/profile/yourusername)
|
||||
- Twitter - [@yourusername](https://www.twitter.com/yourusername)
|
||||
|
||||
**Note: Delete this note and add/remove/edit lines above based on what links you'd like to share.**
|
||||
- Website - [Robert McGovern Blog](https://tarasis.net)
|
||||
- Frontend Mentor - [@tarasis](https://www.frontendmentor.io/profile/tarasis)
|
||||
- Twitter - [@tarasis](https://www.twitter.com/tarasis)
|
||||
- Mastodon - [@tarasis@social.tarasis.net](https://social.tarasis.net/@tarasis)
|
||||
|
||||
## Acknowledgments
|
||||
|
||||
This is where you can give a hat tip to anyone who helped you out on this project. Perhaps you worked in a team or got some inspiration from someone else's solution. This is the perfect place to give them some credit.
|
||||
|
||||
**Note: Delete this note and edit this section's content as necessary. If you completed this challenge by yourself, feel free to delete this section entirely.**
|
||||
Thanks to Grace, Chamu and a-woodworth for trying to answer my Slack question about `srcset`.
|
||||
|
|
@ -85,8 +85,6 @@ body {
|
|||
background: var(--col-white-to-off-white);
|
||||
}
|
||||
|
||||
.header {
|
||||
}
|
||||
.banner {
|
||||
display: flex;
|
||||
justify-content: space-between;
|
||||
|
|
@ -99,9 +97,6 @@ body {
|
|||
vertical-align: center;
|
||||
}
|
||||
|
||||
.banner__logo {
|
||||
}
|
||||
|
||||
.btn {
|
||||
font-size: var(--fs-body-s);
|
||||
line-height: var(--lh-body-s);
|
||||
|
|
@ -172,8 +167,6 @@ body {
|
|||
margin-left: -13%;
|
||||
width: 125%;
|
||||
}
|
||||
.hero_img {
|
||||
}
|
||||
|
||||
main {
|
||||
margin-inline: auto;
|
||||
|
|
@ -249,8 +242,6 @@ main {
|
|||
align-items: center;
|
||||
padding: 2.25rem 1rem;
|
||||
}
|
||||
.footer__logo {
|
||||
}
|
||||
|
||||
.footer__getting-started {
|
||||
background: var(--col-purple-to-pink);
|
||||
|
|
|
|||
Loading…
Reference in New Issue