From aecb4ae2678baf3a10f479fd763fb1f6666cf0e1 Mon Sep 17 00:00:00 2001 From: Robert McGovern Date: Sat, 18 Feb 2023 23:10:20 +0000 Subject: [PATCH] Updates to remove warnings about not using calc There were warnings about using divide without Calc. (and some commented out ie7-8 things from when I was trying to use a different plugin to compile the sass rather than my current technique --- src/_sass/minimal-mistakes/_forms.scss | 16 ++++++++-------- src/_sass/minimal-mistakes/_mixins.scss | 6 +++--- src/_sass/minimal-mistakes/_reset.scss | 6 +++--- .../vendor/breakpoint/_helpers.scss | 6 +++--- .../vendor/magnific-popup/_magnific-popup.scss | 2 +- .../vendor/magnific-popup/_settings.scss | 4 ++-- .../vendor/susy/susy/_su-math.scss | 4 ++-- 7 files changed, 22 insertions(+), 22 deletions(-) diff --git a/src/_sass/minimal-mistakes/_forms.scss b/src/_sass/minimal-mistakes/_forms.scss index 0dd9b48..ca43507 100644 --- a/src/_sass/minimal-mistakes/_forms.scss +++ b/src/_sass/minimal-mistakes/_forms.scss @@ -17,7 +17,7 @@ form { display: block; width: 100%; margin-bottom: 5px * 2; - *margin-left: -7px; + margin-left: -7px; padding: 0; color: $text-color; border: 0; @@ -25,7 +25,7 @@ form { } p { - margin-bottom: (5px / 2); + margin-bottom: calc(5px / 2); } ul { @@ -45,7 +45,7 @@ button, select, textarea { vertical-align: baseline; - *vertical-align: middle; + /*vertical-align: middle; */ } input, @@ -102,7 +102,7 @@ input[type="radio"] { height: auto; padding: 0; margin: 3px 0; - *margin-top: 0; + /* *margin-top: 0; */ line-height: normal; cursor: pointer; border-radius: 0; @@ -114,8 +114,8 @@ input[type="checkbox"], input[type="radio"] { box-sizing: border-box; padding: 0; - *width: 13px; - *height: 13px; +/* *width: 13px; */ +/* *height: 13px; */ } input[type="image"] { @@ -138,12 +138,12 @@ input[type="submit"] { width: auto; height: auto; cursor: pointer; - *overflow: visible; +/* *overflow: visible; */ } select, input[type="file"] { - *margin-top: 4px; +/* *margin-top: 4px; */ } select { diff --git a/src/_sass/minimal-mistakes/_mixins.scss b/src/_sass/minimal-mistakes/_mixins.scss index 4aa9eb0..31423b0 100644 --- a/src/_sass/minimal-mistakes/_mixins.scss +++ b/src/_sass/minimal-mistakes/_mixins.scss @@ -15,7 +15,7 @@ ========================================================================== */ @function em($target, $context: $doc-font-size) { - @return ($target / $context) * 1em; + @return (calc($target / $context)) * 1em; } @@ -65,7 +65,7 @@ $green: green($color); $blue: blue($color); - $yiq: (($red*299)+($green*587)+($blue*114))/1000; + $yiq: calc((($red * 299) + ($green * 587) + ($blue * 114)) / 1000); @if $yiq-debug { @debug $yiq, $threshold; } @@ -89,4 +89,4 @@ ) { background-color: $background-color; color: yiq-contrast-color($background-color, $dark, $light, $threshold); -} \ No newline at end of file +} diff --git a/src/_sass/minimal-mistakes/_reset.scss b/src/_sass/minimal-mistakes/_reset.scss index 2259fd0..ba14602 100644 --- a/src/_sass/minimal-mistakes/_reset.scss +++ b/src/_sass/minimal-mistakes/_reset.scss @@ -64,8 +64,8 @@ audio, canvas, video { display: inline-block; - *display: inline; - *zoom: 1; +/* display: inline; */ +/* zoom: 1; */ } /* Prevents modern browsers from displaying 'audio' without controls */ @@ -142,7 +142,7 @@ textarea { button, input { - *overflow: visible; /* inner spacing ie IE6/7*/ +/* *overflow: visible; */ /* inner spacing ie IE6/7*/ line-height: normal; /* FF3/4 have !important on line-height in UA stylesheet*/ } diff --git a/src/_sass/minimal-mistakes/vendor/breakpoint/_helpers.scss b/src/_sass/minimal-mistakes/vendor/breakpoint/_helpers.scss index 97e522d..da5ef52 100644 --- a/src/_sass/minimal-mistakes/vendor/breakpoint/_helpers.scss +++ b/src/_sass/minimal-mistakes/vendor/breakpoint/_helpers.scss @@ -25,16 +25,16 @@ $unit: unit($value); @if $unit == 'px' { - @return $value / 16px * 1em; + @return calc($value / 16px * 1em); } @else if $unit == '%' { - @return $value / 100% * 1em; + @return calc($value / 100% * 1em); } @else if $unit == 'em' { @return $value; } @else if $unit == 'pt' { - @return $value / 12pt * 1em; + @return calc($value / 12pt * 1em); } @else { @return $value; diff --git a/src/_sass/minimal-mistakes/vendor/magnific-popup/_magnific-popup.scss b/src/_sass/minimal-mistakes/vendor/magnific-popup/_magnific-popup.scss index 27b27bc..16b6cda 100644 --- a/src/_sass/minimal-mistakes/vendor/magnific-popup/_magnific-popup.scss +++ b/src/_sass/minimal-mistakes/vendor/magnific-popup/_magnific-popup.scss @@ -52,7 +52,7 @@ $mfp-include-iframe-type: true !default; $mfp-iframe-padding-top: 40px !default; $mfp-iframe-background: #000 !default; $mfp-iframe-max-width: 900px !default; -$mfp-iframe-ratio: 9/16 !default; +$mfp-iframe-ratio: calc(9/16) !default; // Image-type options $mfp-include-image-type: true !default; diff --git a/src/_sass/minimal-mistakes/vendor/magnific-popup/_settings.scss b/src/_sass/minimal-mistakes/vendor/magnific-popup/_settings.scss index e7866b3..49667b7 100644 --- a/src/_sass/minimal-mistakes/vendor/magnific-popup/_settings.scss +++ b/src/_sass/minimal-mistakes/vendor/magnific-popup/_settings.scss @@ -28,7 +28,7 @@ $mfp-include-iframe-type: true; // Enable Ifra $mfp-iframe-padding-top: 40px; // Iframe padding top $mfp-iframe-background: #000; // Background color of iframes $mfp-iframe-max-width: 900px; // Maximum width of iframes -$mfp-iframe-ratio: 9/16; // Ratio of iframe (9/16 = widescreen, 3/4 = standard, etc.) +$mfp-iframe-ratio: calc(9/16); // Ratio of iframe (9/16 = widescreen, 3/4 = standard, etc.) // Image-type options $mfp-include-image-type: true; // Enable Image-type popups @@ -43,4 +43,4 @@ $mfp-caption-subtitle-color: #bdbdbd; // Caption sub .mfp-counter { font-family: $serif; } // Caption font family // A11y -$mfp-use-visuallyhidden: false; \ No newline at end of file +$mfp-use-visuallyhidden: false; diff --git a/src/_sass/minimal-mistakes/vendor/susy/susy/_su-math.scss b/src/_sass/minimal-mistakes/vendor/susy/susy/_su-math.scss index 1e88528..5164bb7 100644 --- a/src/_sass/minimal-mistakes/vendor/susy/susy/_su-math.scss +++ b/src/_sass/minimal-mistakes/vendor/susy/susy/_su-math.scss @@ -90,7 +90,7 @@ @if unitless($span-width) { $container-spread: su-valid-spread($container-spread); $container: _su-sum($columns, $gutters, $container-spread, $validate: false); - @return percentage($span-width / $container); + @return percentage(calc($span-width / $container)); } @return $span-width; @@ -141,7 +141,7 @@ } $container: _su-sum($columns, $gutters, $container-spread); - @return percentage($gutters / $container); + @return percentage(calc($gutters / $container)); }