tarasis
/
rmcg.dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
286 Commits 6 Branches 1 Tag 55 MiB
Commit Graph

286 Commits

Author SHA1 Message Date
Robert McGovern 6f9c946458 Missing accessibility 2020-10-04 12:06:25 +01:00
Robert McGovern 78e4202963 Fix for html issue and making the share button move. 2020-10-04 12:04:01 +01:00
Robert McGovern a3ad3f54d6 Final styling tweaks. 
Moved share svg inline so I could color it, although better would be to edit the external svg to use fill="currentColor"
Some final notes
 2020-10-04 10:56:44 +01:00
Robert McGovern faad2f4c1d Final before submitting? 2020-10-04 01:15:04 +01:00
Robert McGovern 39d7d415f6 Final tweaks EXCEPT attribution. 2020-10-04 00:57:50 +01:00
Robert McGovern 4eab3313a1 Sharing working, desktop and mobile are close. 
Haven't matched design for sharing.
 2020-10-04 00:34:27 +01:00
Robert McGovern 26ceffebd0 Check in before playing more with flex 2020-10-03 13:05:43 +01:00
Robert McGovern be1504139d Rough image sizing / positioning. 2020-10-01 14:53:16 +01:00
Robert McGovern 83cfde6bda Had forgotten to remove master from the challenge folder name 2020-09-30 23:20:45 +01:00
Robert McGovern 76800cea32 Stopping point for the night / till I get internet back 2020-09-30 23:18:42 +01:00
Robert McGovern af7aac4b1a Added project to base index.html 2020-09-30 21:08:56 +01:00
Robert McGovern 2003d9d1e6 Base project files 2020-09-30 21:04:19 +01:00
Robert McGovern 8243501927 Switched most h1's for h2's. Also top two I had as h1 to paragraphs, neither is really a title/heading, both have importance. (Given "Powered by Technology" is in bold, one might argue its could be an h1) 
Suggestion to consider h1 & accessibility from Matt@Frontend Mentor
 2020-09-28 13:06:27 +01:00
Robert McGovern 06985ea3c0 Flex on the brain. Should have just used normal Flow, and set display:block on the image. 
Thank you to Matt@Frontend Mentor for that suggestion.
 2020-09-28 12:55:33 +01:00
Robert McGovern 9a350e45be Finished. 2020-09-27 23:36:12 +01:00
Robert McGovern 853481f3b8 Point at which I'm happy with the mobile to sign off on it. 2020-09-27 16:20:14 +01:00
Robert McGovern a1e4c4e86f Mobile version in place, except shadows on cards. 2020-09-27 15:46:19 +01:00
Robert McGovern 707dab7732 basic stylings, chasing mobile design. More in the morning. 2020-09-27 00:41:30 +01:00
Robert McGovern 9f3843c8c1 First pass at marking up the html, and added classes. (Although I don't think I'll need some) 
Extracted classes into the style.css
 2020-09-27 00:03:33 +01:00
Robert McGovern dee9c96fd3 Added basic styling to style.css, and linked it into the html. 2020-09-26 23:05:06 +01:00
Robert McGovern f61e1bf053 Merge branch 'master' into four-card-feature-section 2020-09-24 10:46:51 +01:00
Robert McGovern 7686db64a3 "Better" dynamic css. No longer using any media queries. Boxes will take up 90% of the screen on mobile devices, then will max out at 700px. 
Font in the header (Practice Projects), will scale from 2.5rem on mobile, to 3rem for larger screens.

Should work for 80-88% of web browsers according to caniuse.com. Should probably provide a fallback

Might in future also scale the body text size too.
 2020-09-24 10:45:56 +01:00
Robert McGovern 7413fc6c78 Merge branch 'master' into four-card-feature-section 2020-09-24 09:41:30 +01:00
Robert McGovern d12dd9fa0a Guess who forgot the mobile friendly formatting. 
Added formatting that looks okay on my mobile (iPhone 6S)
 2020-09-24 09:41:04 +01:00
Robert McGovern babbdc94e9 Updated progress about the lack of progress 🤣 2020-09-24 00:40:37 +01:00
Robert McGovern 103814ec41 Merge branch 'master' into four-card-feature-section 2020-09-24 00:37:16 +01:00
Robert McGovern 7310427c8e First pass at a styled front page. Have some ideas of things to do, which are mentioned in the CSS file :) 2020-09-24 00:36:00 +01:00
Robert McGovern 9f7711fb61 Initial challenge files 2020-09-23 22:50:58 +01:00
Robert McGovern 24a7398cc8 Forgot to add the differences for Single Price challenge 2020-09-23 17:10:05 +01:00
Robert McGovern ad00958ac9 process doc 2020-09-23 15:08:03 +01:00
Robert McGovern efd75b9651 chasing desktop 2020-09-23 15:06:31 +01:00
Robert McGovern 2cd47ac19a Close as I'm going for mobile 2020-09-23 14:59:24 +01:00
Robert McGovern c2a59f697f Work in progress 2020-09-12 12:18:25 +01:00
Robert McGovern 4b1e46d0a3 Formatted html as I think it should go. Awful class names right now. 2020-09-12 10:49:10 +01:00
Robert McGovern 53abbe6c9e Set up basic styling per the style guide 2020-09-12 10:16:18 +01:00
Robert McGovern 58ee69ff20 Added a workspace file for VSCode, not sure about using it or not. Might back this out, if nothing else because I dislike that it not puts it into its own folder in the Explorer. 2020-09-12 09:50:53 +01:00
Robert McGovern abab57c744 Base files for the single price grid component challenge, updated base index.html to point to this project and setup a process doc 2020-09-12 09:37:02 +01:00
Robert McGovern fcfccd4a5a Added final images & difference comparisons 2020-09-11 23:28:26 +01:00
Robert McGovern e8d65b4e73 Fixes for accessibility errors 2020-09-11 23:05:10 +01:00
Robert McGovern 000c8ab449 Merge branch 'ping-coming-soon' 2020-09-11 22:40:14 +01:00
Robert McGovern d5843c5019 Final positioning. Figured out using flexbox ordering would allow me to have the error message first in the row, then I only needed to shift it downwards. 2020-09-11 22:39:04 +01:00
Robert McGovern 4971c7c7f9 slight tidyup 2020-09-11 21:49:27 +01:00
Robert McGovern b159136955 Fixed position of the social icons 2020-09-11 21:47:09 +01:00
Robert McGovern 31e73d0dbb Have a working solution for the error message at desktop size, but it only looks good at the expected 1440x1024. Need a better solution. Somehow calculate placement? 2020-09-10 00:28:40 +01:00
Robert McGovern bfb154d80d Social icons have a better circular border and have hover states. 2020-09-09 23:37:34 +01:00
Robert McGovern 22f6907743 Error state for mobile done ... well there are things to do. Placeholder text could be nudged. The email text positioning could be moved too. 
There is JavaScript functions to clear error state, show error, and validate email address.
 2020-09-09 21:16:23 +01:00
Robert McGovern 317f2bdbb8 Added a "notebook" 2020-09-09 12:34:48 +01:00
Robert McGovern ffae93aedd some more notes 2020-09-09 00:52:09 +01:00
Robert McGovern 2aa0935fa7 Notes on next steps to complete project 2020-09-09 00:03:16 +01:00
Robert McGovern 175c016d40 CSS cleanup 2020-09-08 23:59:34 +01:00